Migrates 'spe' commands to Zod. Closes #7317#7426
Open
MartinM85 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the migration of SPE commands to the CLI’s Zod-based option/schema validation, updating both command implementations (exported options + schema getters) and their Mocha specs to validate options via commandInfo.command.getSchemaToParse().
Changes:
- Migrated
spe containertype listto Zod usingglobalOptionsZod.strict(). - Migrated
spe container activateandspe container listto Zod with exportedoptionsschemas and updated command classes. - Updated specs to use
commandOptionsSchema.parse(...)/safeParse(...)rather than legacycommand.validate(...).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/spe/commands/containertype/containertype-list.ts | Adds Zod schema integration for global-only options. |
| src/m365/spe/commands/containertype/containertype-list.spec.ts | Updates tests to parse options through the command’s schema. |
| src/m365/spe/commands/container/container-list.ts | Replaces legacy option/validator/optionSet logic with Zod schema + refinement. |
| src/m365/spe/commands/container/container-list.spec.ts | Updates validation/action tests to use the refined Zod schema. |
| src/m365/spe/commands/container/container-get.spec.ts | Adjusts action tests to pass schema-parsed options. |
| src/m365/spe/commands/container/container-activate.ts | Adds Zod schema (with alias) and removes legacy option init. |
| src/m365/spe/commands/container/container-activate.spec.ts | Updates tests to pass schema-parsed options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7317