Skip to content

fix: drop log.type from the generated pnpr config - #82

Merged
zkochan merged 1 commit into
mainfrom
pnpr-drop-log-type
Nov 13, 2026
Merged

zkochan merged 1 commit into
mainfrom
pnpr-drop-log-type

Conversation

@zkochan

@zkochan zkochan commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

pnpm/pnpm#18030 removes pnpr's log.type setting. After that, @pnpm/pnpr@next rejects the config startPnpr() writes, because it contains type: stdout.

pnpr always logged to stdout, so without this line the config means the same thing to the pnpr releases already published. This can merge before pnpm/pnpm#18030.


Written by an agent (Claude Code, claude-opus-5-5).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Logging
    • pnpr output is now written to pnpr.log rather than sent to standard output. The existing log format and configured log level are unchanged.

pnpr no longer accepts log.type. It always logged to stdout, so the
config means the same to the pnpr releases already published.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pnpr configuration no longer sets the log type to stdout. It retains the pretty format and configured log level. Existing process wiring writes output to pnpr.log.

Changes: pnpr logging configuration

Layer / File(s) Summary
Log destination configuration
pnprServer.js
The configuration no longer sets type: stdout. It retains the pretty format and configured log level. Existing process wiring writes output to pnpr.log.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: Minimal · up to d88e6

The change drops an explicit log type from the generated pnpr config, so newer pnpr releases that reject that setting can still start. Behavior with existing releases should be unchanged, because the output still goes to the same log file. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title 'fix: drop log.type from the generated pnpr config' matches the changeset. The diff removes the log type setting (type: stdout) from the pnpr config that startPnpr() writes, and the PR objec…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title 'fix: drop log.type from the generated pnpr config' matches the changeset. The diff removes the log type setting (type: stdout) from the pnpr config that startPnpr() writes, and the PR objectives state the same removal. The title is specific, short, and one sentence, so it describes the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the logging flow,
No stdout setting in the show.
Pretty logs keep their chosen hue,
The configured level stays true.
Into pnpr.log the traces go.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c91d3956-c035-4ce4-9cce-52a9700f9728
Commits

Reviewing files that changed from the base of the PR and between 07df9af and d88e64e.

Files selected for processing: 1

  • pnprServer.js
Files with no reviewable changes: 1

  • pnprServer.js

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

Recent review details

Context from checks skipped due to timeout: 3

  • GitHub Check: CodeRabbit
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove unsupported log.type from generated pnpr config

🐞 Bug fix 🕐 Less than 5 minutes

Grey Divider

AI Description

• Remove log.type: stdout so newer pnpr releases accept the generated configuration.
• Preserve existing logging behavior because pnpr already defaults to stdout.
High-Level Assessment

Removing the unsupported setting is the simplest compatible approach. Replacing it with another output setting is unnecessary because stdout is already pnpr's default.

Files changed (1) +0 / -1

Bug fix (1) +0 / -1
pnprServer.jsOmit log.type from generated pnpr.yaml +0/-1

Omit log.type from generated pnpr.yaml

• Removes 'type: stdout' from the log section written by 'startPnpr()'. The generated configuration remains compatible with newer pnpr releases without changing where pnpr logs.

pnprServer.js

@zkochan
zkochan merged commit 6fd573a into main Nov 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant