Skip to content

Feat/conditional values refactor#207

Closed
angelo-v wants to merge 114 commits into
mainfrom
feat/conditional-values-refactor
Closed

Feat/conditional values refactor#207
angelo-v wants to merge 114 commits into
mainfrom
feat/conditional-values-refactor

Conversation

@angelo-v

@angelo-v angelo-v commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

re-created PR because github shows false-positive merge conflicts

jg10-mastodon-social and others added 30 commits July 14, 2026 10:44
@jg10-mastodon-social @angelo-v
feat(pos-switch): if-property filters by some-value-eq
857bcc8
@jg10-mastodon-social @angelo-v
feat(pos-switch): if-rev filters by some-value-eq
79dcf1c
@jg10-mastodon-social @angelo-v
feat(pos-switch): compareValue supports every-value-eq
2fddd40
@jg10-mastodon-social @angelo-v
feat(Thing): add basic observeLiterals
4e3f80c
@jg10-mastodon-social @angelo-v
feat(Thing): observeLiterals updates after additions
b3408e8
@jg10-mastodon-social @angelo-v
feat(Thing): observeLiterals pushes updates in groups
6317ee6
@jg10-mastodon-social @angelo-v
feat(Thing): observeLiterals ignores statements about other resources
9c2e43d
@jg10-mastodon-social @angelo-v
feat(Thing): observeLiterals does not push if literals have not changed
d673951
@jg10-mastodon-social @angelo-v
feat(pos-switch): if-property takes literals into account
c6fb238
@jg10-mastodon-social @angelo-v
chore(Thing): lint and typecheck
59e3274
@jg10-mastodon-social @angelo-v
feat(pos-switch): compareValue supports (some|every)-value-(eq|gt|gte…
9614855 
…|lt|lte)
@jg10-mastodon-social @angelo-v
feat(pos-switch): compareValue supports numbers
44c8883
@jg10-mastodon-social @angelo-v
test(pos-switch): add value-based example to integration test
453edf9
@jg10-mastodon-social @angelo-v
doc(pos-case): add value testing attributes
146d08d
@jg10-mastodon-social @angelo-v
doc(Thing): add doc string for observeLiterals
af1d7e8
@jg10-mastodon-social @angelo-v
doc(core): add observeLiterals to changelog
d727826
@jg10-mastodon-social @angelo-v
doc(elements): add pos-switch value testing to changelog
85bd2a7
@jg10-mastodon-social @angelo-v
doc: add pos-switch value testing to storybook
60b2865
@angelo-v
refactor: generalize function to observe changes
98f9d8b
@angelo-v
test(pos-switch): negation (absense) of property or backward link
a86e62a
@angelo-v
test(pos-switch): prepare data driven test for several conditions
5e30a6e
@angelo-v
test(pos-switch): add more test cases, including failing ones highlig…
bfa7ba0 
…ting bugs
@angelo-v
fix(core): export type Quad to prevent implicit type any
a3feea2
@jg10-mastodon-social @angelo-v
fix(pos-switch): not is applied after comparing values
42db1aa
@jg10-mastodon-social @angelo-v
test(pos-switch): not if-property some-value-eq passes
8313c0a
@jg10-mastodon-social @angelo-v
test(pos-switch): group tests; extract tests for test method
906eb74
@jg10-mastodon-social @angelo-v
test(pos-switch): group reactivity tests
5e97f07
@jg10-mastodon-social @angelo-v
test(pos-switch): test if-typeof attribute combinations
4781bc5
@jg10-mastodon-social @angelo-v
test(pos-switch): handle type checks with multiple values
b1e8f99
@jg10-mastodon-social @angelo-v
test(pos-switch): if-property presence/absence combinatorial tests
bea4968
angelo-v added 28 commits July 16, 2026 17:27
@angelo-v
fix(pos-switch): renders the else case if it is the only case present
8608ca2
@angelo-v
fix: keep track of if-else scopes to correlate and else branch with t…
7e81848 
…he correct if
@angelo-v
test: integration test for value matching
5bf7c70
@angelo-v
test: integration test to ensure cases are re-evaluated when resource…
600c392 
… changes
@angelo-v
test: "if -> else if -> else" rule combination
45c03d9
@angelo-v
test: "if -> else if, if -> else if" rule combination
1b83bdf
@angelo-v
test: "if -> else, if -> else" rule combination
20357d6
@angelo-v
test: rule combinations with negations "if not -> else if not -> else"
bf12b9a
@angelo-v
test: integration test rule negation
543500a
@angelo-v
test: integration test greater / less than comparisons
dc487ff
@angelo-v
test(pos-case): provide else and not for all rule types
2910402
@angelo-v
test: add missing test for if-typeof when only the wrong type is present
52e7b55
@angelo-v
test: add missing test for if-property presence
829717b
@angelo-v
test: add missing test for if-rev presence
cf51f8a
@angelo-v
test: throw error for unknown semantic
fc8074c
@angelo-v
test: negation of if-property with specific value
62f009a
@angelo-v
test: negation of if-property with specific relation
e6e304c
@angelo-v
test: negation of if-rev with specific reverse relation
3142a1a
@angelo-v
test: add integration test to verify the cases update after data has …
71b8445 
…been changed
@angelo-v
chore: remove old obsolete test suite
c641980 
while the pos-switch.test.spec.tsx had a very exhaustive combinatoric, the new vitest suite handles that complexity by breaking down then responsibilities. In sum, everything covered before is still covered, even more.
@angelo-v
refactor: determine by rule which data to observe, instead of checkin…
c76c395 
…g for element properties
@angelo-v
test: add tests for all observed values (types, literals, relations, …
0c6e22d 
…reverse relations) to make sure they are reset properly when resource changes
@angelo-v
refactor: simplify subscribing to observed values.
0f1adeb 
Since all observe* methods of Thing use startWith, they return a value immediately effectively. The `firstValueFrom(combineLatest...` approach appears to be overly defensive in that regard and gets simplified
@angelo-v
refactor: build the full rule context at once from relevant observed …
dc8f727 
…values
@angelo-v
feat: pos-case renders its own template based on an active state cont…
cdd2a0e 
…rolled by pos-switch

this gives pos-case the control of what to render and if.
@angelo-v
test: fix jsx config also for integration tests
83636fc 
same as in commit 0ef0a0d
@angelo-v
feat: show misconfigured pos-case rules to the user
dc12e61
@angelo-v
feat: add some basic styling to errors to distinguish them from norma…
a3332a3 
…l rendering and make the user better aware of a problem
@angelo-v

angelo-v commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

duplicate PR due to githun merge conflict false-positive

@angelo-v angelo-v closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angelo-v @jg10-mastodon-social