mac_pw_pool: fix DHSTATE default falling back to $PWSTATE - #43
Open
ROKUMATE wants to merge 1 commit into
Open
Conversation
Signed-off-by: ROKUMATE <rohitkumawat0110@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a leftover from the rename in 8aa0ffd — that commit wrote line 29 using the old
variable name, and e427ad3 added the real
PWSTATEat line 39 shortly after.Nothing sets
PWSTATEin the environment today .. so the fallback always fires andDHSTATEalready resolves to
dh_status.txt... no change in current behavior ... but line 39 does supportoverriding
PWSTATE, and if you use it both variables end up pointing at the same file ...LaunchInstances.sh:307-310andSetupInstances.sh:507-510each docp "$X" "${X}~"thenmv tmp "$X", so host state would land inpw_status.txtandSetupInstances.sh:108-128would read host records as instance records.Side effect: this also clears the
SC2034 DHSTATE appears unusedshellcheck warning on that line(20 findings in the file, now 19).