images, scripts: small hardening - #44
Open
vtushar06 wants to merge 2 commits into
Open
Conversation
testdigest_v2s2:20200210 is listed twice, so cache_images does a second skopeo copy of the same image from quay on every image build. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
The upload curl has no retry and the loop runs under set -e, so one transient error aborts it with some artifacts uploaded and no release created. --retry 5 matches images/build.sh; --retry-all-errors is needed because plain --retry does not cover 5xx under --fail, and the PAR upload is idempotent. Signed-off-by: Tushar Verma <tusharmyself06@gmail.com>
vtushar06
force-pushed
the
ci-hardening
branch
from
August 14, 2026 13:57
ed2aa37 to
3909350
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things I ran into while looking at the image scripts.
The cache list in images/local-cache-registry has
testdigest_v2s2:20200210twice (lines 87 and 94), so image builds do one extra full skopeo copy of it from quay. Harmless, just redundant.The release upload curl in scripts/upload-to-oci-par.sh has no --retry, and with
set -ea single transient failure aborts the loop mid-way - some artifacts uploaded, no release created. The release job comment already mentions hoping for better network, so this seemed worth hardening. I used--retry 5to match images/build.sh, plus--retry-all-errorssince plain --retry does not retry 5xx under --fail. The PUT is idempotent so retrying should be safe.I only tested that both scripts still parse - I can't exercise the release path myself.