docs: remove getOrders from the orderbook precompile reference#234
Draft
claude[bot] wants to merge 1 commit into
Draft
docs: remove getOrders from the orderbook precompile reference#234claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
The getOrders eth_call method is being removed from the orderbook precompile (podnetwork/pod): it duplicated the RPC read path and has returned incorrect data since Dec 2025. Point readers at ob_getOrders and the read-market-data guide for order state instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01A74BZVmHFAksnZWVaGBcgi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Alex Brezas · Slack thread
Before
The orderbook precompile reference documented a
getOrders(bytes32 orderbookId, bytes32[] orderIds)eth_call read, and the API-reference pages mentioned it as one of the precompile's read-only methods. The method is being removed from the node (podnetwork/pod#1397): it duplicated the RPC read path and had returned unusable data (aremainingBaseof ~2^256 for any order not fully filled, and astartTsthat echoedendTs) since podnetwork/pod#403 landed in Dec 2025.After
The docs no longer describe
getOrderson the precompile. Order state and history reads point at the existing RPC read path instead —ob_getOrdersand the Read market data guide — consistent with how the rest of the page already references order reads. Balance reads (balanceOf,withdrawableBalance,getBalance) on the precompile are unchanged.How
doc/api-reference/applications-precompiles/orderbook.md— removed thegetOrdersABI entry and docblock; the intro now points order-state reads at theob_JSON-RPC endpoints; theorder_idhint no longer listsgetOrders.doc/api-reference/README.md— droppedgetOrdersfrom the order-id hint.doc/api-reference/json-rpc/openapi.yamlanddoc/api-reference/.gitbook/assets/openapi.yaml— removed thegetOrdersbullet from theeth_calldescription.Note: this PR only touches
doc/api-reference/*; it does not overlap with #231 (which editsdoc/protocol/orderbook.md). No SDK code (rust-sdk, ts-sdk, types, solidity-sdk, examples) referenced the precompilegetOrders.🤖 Generated with Claude Code
https://claude.ai/code/session_01A74BZVmHFAksnZWVaGBcgi
Generated by Claude Code