Skip to content

Fix tutorial Badge#1676

Merged
eshaben merged 5 commits into
masterfrom
0xlukem/fix-tutorial-badges
May 19, 2026
Merged

Fix tutorial Badge#1676
eshaben merged 5 commits into
masterfrom
0xlukem/fix-tutorial-badges

Conversation

@0xlukem
Copy link
Copy Markdown
Contributor

@0xlukem 0xlukem commented May 13, 2026

📝 Description

This pull request makes a minor update to the frontmatter of the core-v2.md documentation file for Uniswap V2 Core. The change restructures how the tutorial_badge is defined in the metadata, moving it under a new page_badges section for improved organization.

🔍 Review Preference

Choose one:

  • ✅ I have time to handle formatting/style feedback myself
  • ⚡ Docs team handles formatting (check "Allow edits from maintainers")

✅ Checklist

Copilot AI review requested due to automatic review settings May 13, 2026 21:23
@0xlukem 0xlukem requested a review from a team as a code owner May 13, 2026 21:23
@0xlukem 0xlukem added B0 - Needs Review Pull request is ready for review C0 - Low Low priority task A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels May 13, 2026
@0xlukem 0xlukem requested a review from eshaben May 13, 2026 21:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restructures the frontmatter in the Uniswap V2 Core tutorial doc so the tutorial_badge field is nested under a new page_badges section.

Changes:

  • Move tutorial_badge: Intermediate under a page_badges parent key in the frontmatter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Are the other guides being audited and badges added as needed in a separate PR?

@0xlukem 0xlukem requested a review from eshaben May 15, 2026 15:44
@eshaben eshaben requested a review from nhussein11 May 19, 2026 12:15
Copy link
Copy Markdown
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhussein11 can you pls review to make sure each badge difficulty is correct?

Approving now so I don't hold up the PR

Comment thread chain-interactions/send-transactions/calculate-transaction-fees.md Outdated
Comment thread chain-interactions/store-data/bulletin-chain.md Outdated
Comment thread parachains/customize-runtime/pallet-development/create-a-pallet.md Outdated
Co-authored-by: Nicolás Hussein <80422357+nhussein11@users.noreply.github.com>
@0xlukem 0xlukem requested a review from eshaben May 19, 2026 12:36
@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels May 19, 2026
@eshaben eshaben merged commit bbdc9bf into master May 19, 2026
10 of 11 checks passed
@eshaben eshaben deleted the 0xlukem/fix-tutorial-badges branch May 19, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged C0 - Low Low priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants