Repository navigation
Show numbered tab chips with agent status in workspace rows - #517
Merged
Merged
Conversation
powerfooI
force-pushed
the
feat/workspace-tab-chips
branch
from
October 30, 2026 02:19
1054f08 to
528c499
Compare
powerfooI
approved these changes
Oct 30, 2026
powerfooI
left a comment
Owner
There was a problem hiding this comment.
Reviewed the chip builder, urgency ordering, layout observer, current-server focus, and generation-bound cross-server navigation. Fixed keyboard reachability and restored the local navigation callback; strengthened the remote-tab fixture to verify its exact pane. Nine related tests, build:web, formatting, native types/lint, CI, and CodeQL pass. In the macOS in-app browser against an isolated real Herdr backend, keyboard activation opens tab 2 and restores terminal focus; shrinking the sidebar folds eight tabs to 1 +7 without horizontal overflow. No remaining blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #515.
Workspace rows show numbered tab chips colored by the most urgent agent state in each tab. Clicking a chip opens its tab on the original server; narrow rows fold extra chips into a +N marker. Chips support keyboard focus and activation, and opening a local tab preserves the application's inspector/terminal navigation behavior.
The prerequisite badge alignment fix (#514) is merged, and this branch is rebased onto it.
Verification
bun test web/src/components/WorkspaceTree.test.ts web/src/components/WorkspaceTree.servers.test.ts web/src/workspaceTabChips.test.ts web/src/useAllServerAgentSessions.test.ts: 9 passed.bun run build:web: passes; initial JS 803.9/805 KiB.Compatibility
No API, protocol, or settings changes. The combined asset budget will be checked again when #518 lands.