Repository navigation
Clip worktree and branch names at the start in the workspace list - #528
Merged
Merged
Conversation
A worktree nested under its repository mostly repeats the repository's name, and branch names share prefixes (task/, a user name): what tells them apart is their end. Their labels now keep the end and clip the start (…ject-system-iga-184, …video-direction); the full name stays in the tooltip. Top-level workspace names still clip at the end. The initial JS goes from 805.0 to 805.1 KiB, so its budget moves from 805 to 806 KiB.
Owner
|
Reviewed the start ellipsis CSS, isolated inner text, child-row targeting, and full-name tooltip behavior. Combined verification on current main plus all six contributions: I could not repeat browser visual checks: computer-use access was blocked by the current browser URL policy. The author's prior Chrome check remains the available visual evidence; Safari/Firefox and RTL rendering were not rechecked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the workspace list, a worktree nested under its repository mostly repeats the repository's name, and branch names share prefixes (
task/, a user name). Both clipped at the end, so the part that tells them apart was the part that got cut.Nested worktree names and branch badges now clip at the start and keep the end (
…ject-system-iga-184,…video-direction). The full name stays in the tooltip. Top-level workspace names still clip at the end.Changes
.start-ellipsisinWorkspaceTree.css: a right-to-left box, so the ellipsis is drawn at the start, with an isolated left-to-right inner span so the text itself is unchanged.WorkspaceRowapplies it to child rows' labels;GitStatusBadgesapplies it to the branch badge.scripts/check-web-assets.mjs: the initial JS budget moves from 805 to 806 KiB.mainwas at 805.0/805 KiB; this change puts it at 805.1 KiB.Verification
bun test web/src/components/WorkspaceTree.test.ts web/src/components/WorkspaceTree.servers.test.ts web/src/components/ModalDialogs.test.ts: 3 pass, 0 fail (label and branch text content unchanged).bun run format:checkon the changed files: clean.bun run lint: clean apart from the existingTerminalView.tsxexhaustive-deps warning.bun run typecheck: passes, including the web build and asset budget check (initial JS 805.1/806 KiB).bun run test:quickwith an isolatedHOME, onmainplus this change and the other small fixes I am sending alongside: 3965 pass, 4 skip, 2 fail. Both failures (useMobileControlsDrag.keyboard.test.tsand the SSH paths test) fail the same way onmainon macOS.Checked before this rebase in Chrome with a long nested worktree name and branch. Not repeated on this branch, and not checked in Safari or Firefox.
Manual checks:
Compatibility
Markup and CSS only.