Cache prepared statements in web workers#1020
Draft
simolus3 wants to merge 3 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: 4767ef2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
preparedStatementsCacheoption to web databases, which controls the size of a cache for prepared statements. When set to a value greater than zero, workers store an LRU cache with the configured maximum capacity for statements.Caching statements can improve performance by not having to prepare common queries every time they run. In particular, this can have a positive effect for watched queries and internal statements like
powersync_controlinvocations. The statement cache is currently disabled by default.Ideally, we should also do this in the Node.js SDK. However, we also shouldn't cache
EXPLAINstatements as they are only evaluated on the first prepare and thus don't reflect schema changes. Neitherbetter-sqlite3nornode:sqlite3exposes a way for us to know whether a statement is anEXPLAIN, so we can't safely cache those.AI use: Manually implemented, then revised with Claude Code.