Fix draw rectangle in BufferedDrawNode not being aligned with framebuffer rectangle - #6670
Open
minetoblend wants to merge 2 commits into
Open
Fix draw rectangle in BufferedDrawNode not being aligned with framebuffer rectangle#6670minetoblend wants to merge 2 commits into
minetoblend wants to merge 2 commits into
GitHub Actions / Results
failed
Nov 17, 2025 in 1s
25482 passed, 2 failed and 636 skipped
| Report | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| TestResults-Linux-MultiThreaded-Debug.trx | 3185✅ | 80⚪ | 254s | |
| TestResults-Linux-MultiThreaded-Release.trx | 3185✅ | 80⚪ | 240s | |
| TestResults-Linux-SingleThread-Debug.trx | 3185✅ | 80⚪ | 192s | |
| TestResults-Linux-SingleThread-Release.trx | 3185✅ | 80⚪ | 163s | |
| TestResults-macOS-MultiThreaded-Debug.trx | 3186✅ | 79⚪ | 635s | |
| TestResults-macOS-SingleThread-Debug.trx | 3184✅ | 2❌ | 79⚪ | 340s |
| TestResults-Windows-MultiThreaded-Debug.trx | 3186✅ | 79⚪ | 303s | |
| TestResults-Windows-SingleThread-Debug.trx | 3186✅ | 79⚪ | 225s |
✅ TestResults-Linux-MultiThreaded-Debug.trx
3265 tests were completed in 254s with 3185 passed, 0 failed and 80 skipped.
✅ TestResults-Linux-MultiThreaded-Release.trx
3265 tests were completed in 240s with 3185 passed, 0 failed and 80 skipped.
✅ TestResults-Linux-SingleThread-Debug.trx
3265 tests were completed in 192s with 3185 passed, 0 failed and 80 skipped.
✅ TestResults-Linux-SingleThread-Release.trx
3265 tests were completed in 163s with 3185 passed, 0 failed and 80 skipped.
✅ TestResults-macOS-MultiThreaded-Debug.trx
3265 tests were completed in 635s with 3186 passed, 0 failed and 79 skipped.
❌ TestResults-macOS-SingleThread-Debug.trx
3265 tests were completed in 340s with 3184 passed, 2 failed and 79 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Framework.Tests.Clocks.DecouplingFramedClockTest | 33✅ | 1❌ | 4s | |
| osu.Framework.Tests.Clocks.InterpolatingFramedClockTest | 11✅ | 1❌ | 39s |
❌ osu.Framework.Tests.Clocks.DecouplingFramedClockTest
✅ TestBackwardPlaybackOverZeroBoundary
✅ TestChangeSourceUpdatesToCorrectSourceState(False)
✅ TestChangeSourceUpdatesToCorrectSourceState(True)
✅ TestChangeSourceUpdatesToNewSourceTime(False)
✅ TestChangeSourceUpdatesToNewSourceTime(True)
✅ TestForwardPlaybackOverLengthBoundary
✅ TestForwardPlaybackOverZeroBoundary
❌ TestNoDecoupledDrift(0)
Expected: -6.2938750000000141d +/- 1
But was: -7.7537920000000042d
Off by: 1.4599169999999901d
✅ TestNoDecoupledDrift(1)
✅ TestNoDecoupledDrift(10)
✅ TestNoDecoupledDrift(50)
✅ TestPlayDifferentSourceAfterSeekFailure
✅ TestReset(False)
✅ TestReset(True)
✅ TestSeekBeyondLengthWhileDecoupling
✅ TestSeekFromDecoupling(False)
✅ TestSeekFromDecoupling(True)
✅ TestSeekFromDecouplingWithoutProcessFrame
✅ TestSeekFromNegativeToBeyondLengthWhileDecoupling
✅ TestSeekFromSource(False)
✅ TestSeekFromSource(True)
✅ TestSeekFromSourceWhileDecoupling
✅ TestSeekNegativeWhileDecoupling
✅ TestSeekNegativeWhileNotDecoupling
✅ TestSeekPositiveWhileDecoupling
✅ TestSeekPositiveWhileNotDecoupling
✅ TestSourceStoppedWhileDecoupling
✅ TestSourceStoppedWhileNotDecoupling
✅ TestStartFromDecoupling(False)
✅ TestStartFromDecoupling(True)
✅ TestStartFromNegativeTimeIncrementsCorrectly(False)
✅ TestStartFromNegativeTimeIncrementsCorrectly(True)
✅ TestStartFromSource(False)
✅ TestStartFromSource(True)
❌ osu.Framework.Tests.Clocks.InterpolatingFramedClockTest
✅ CanSeekBackwards
✅ CanSeekForwardsOnInterpolationFail
✅ InterpolationStaysWithinBounds
✅ NeverInterpolatesBackwards
✅ NeverInterpolatesBackwardsOnInterpolationFail
✅ SourceChangeTransfersValueAdjustable
✅ SourceChangeTransfersValueNonAdjustable
✅ TestInterpolationAfterSourceStoppedThenSeeked
✅ TestNoInterpolationDrift(0)
❌ TestNoInterpolationDrift(1)
Expected: 214.23824999999999d +/- 1
But was: 213.22293781840983d
Off by: 1.0153121815901613d
✅ TestNoInterpolationDrift(10)
✅ TestNoInterpolationDrift(50)
✅ TestResults-Windows-MultiThreaded-Debug.trx
3265 tests were completed in 303s with 3186 passed, 0 failed and 79 skipped.
✅ TestResults-Windows-SingleThread-Debug.trx
3265 tests were completed in 225s with 3186 passed, 0 failed and 79 skipped.
Annotations
Check failure on line 0 in TestResults-macOS-SingleThread-Debug.trx
github-actions / Results
osu.Framework.Tests.Clocks.DecouplingFramedClockTest ► TestNoDecoupledDrift(0)
Failed test found in:
TestResults-macOS-SingleThread-Debug.trx
Error:
Expected: -6.2938750000000141d +/- 1
But was: -7.7537920000000042d
Off by: 1.4599169999999901d
Raw output
Expected: -6.2938750000000141d +/- 1
But was: -7.7537920000000042d
Off by: 1.4599169999999901d
at osu.Framework.Tests.Clocks.DecouplingFramedClockTest.TestNoDecoupledDrift(Int32 updateRate) in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Clocks/DecouplingFramedClockTest.cs:line 452
1) at osu.Framework.Tests.Clocks.DecouplingFramedClockTest.TestNoDecoupledDrift(Int32 updateRate) in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Clocks/DecouplingFramedClockTest.cs:line 452
Check failure on line 0 in TestResults-macOS-SingleThread-Debug.trx
github-actions / Results
osu.Framework.Tests.Clocks.InterpolatingFramedClockTest ► TestNoInterpolationDrift(1)
Failed test found in:
TestResults-macOS-SingleThread-Debug.trx
Error:
Expected: 214.23824999999999d +/- 1
But was: 213.22293781840983d
Off by: 1.0153121815901613d
Raw output
Expected: 214.23824999999999d +/- 1
But was: 213.22293781840983d
Off by: 1.0153121815901613d
at osu.Framework.Tests.Clocks.InterpolatingFramedClockTest.TestNoInterpolationDrift(Int32 updateRate) in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Clocks/InterpolatingFramedClockTest.cs:line 269
at InvokeStub_InterpolatingFramedClockTest.TestNoInterpolationDrift(Object, Span`1)
1) at osu.Framework.Tests.Clocks.InterpolatingFramedClockTest.TestNoInterpolationDrift(Int32 updateRate) in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Clocks/InterpolatingFramedClockTest.cs:line 269
at InvokeStub_InterpolatingFramedClockTest.TestNoInterpolationDrift(Object, Span`1)
Loading