Skip to content

Decompose flow aim evaluator into several methods - #38202

Open
tsunyoku wants to merge 5 commits into
ppy:pp-devfrom
tsunyoku:decompose-flow-eval
Open

Decompose flow aim evaluator into several methods#38202
tsunyoku wants to merge 5 commits into
ppy:pp-devfrom
tsunyoku:decompose-flow-eval

Conversation

@tsunyoku

Copy link
Copy Markdown
Member

Same idea as #38201.

Comment thread osu.Game.Rulesets.Osu/Difficulty/Evaluators/Aim/FlowAimEvaluator.cs Outdated
Comment thread osu.Game.Rulesets.Osu/Difficulty/Evaluators/Aim/FlowAimEvaluator.cs Outdated
Comment thread osu.Game.Rulesets.Osu/Difficulty/Evaluators/Aim/FlowAimEvaluator.cs Outdated
@stanriders stanriders moved this to Pending Review in Difficulty calculation changes Jul 20, 2026
Comment thread osu.Game.Rulesets.Osu/Difficulty/Evaluators/Aim/FlowAimEvaluator.cs Outdated
@tsunyoku tsunyoku closed this Aug 5, 2026
@tsunyoku
tsunyoku force-pushed the decompose-flow-eval branch from 4a5ffd0 to 2655d7b Compare August 5, 2026 17:32
@github-project-automation github-project-automation Bot moved this from Pending Review to In Progress in Difficulty calculation changes Aug 5, 2026
@pull-request-size pull-request-size Bot added size/XS and removed size/L labels Aug 5, 2026
@tsunyoku tsunyoku reopened this Aug 5, 2026
@pull-request-size pull-request-size Bot added size/L and removed size/XS labels Aug 5, 2026
@peppy

peppy commented Aug 14, 2026

Copy link
Copy Markdown
Member

Also requires a spreadsheet run I think? Looks okay on paper if it matches.

@tsunyoku

Copy link
Copy Markdown
Member Author

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#38202

@github-actions

Copy link
Copy Markdown

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/31888592390

@tsunyoku

Copy link
Copy Markdown
Member Author

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#38202

@github-actions

Copy link
Copy Markdown

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/32760628767

@github-actions

Copy link
Copy Markdown

@tsunyoku

Copy link
Copy Markdown
Member Author

I'm going to assume the losses are from changes pushed into pp-dev. Will update branch and run again

@tsunyoku

Copy link
Copy Markdown
Member Author

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#38202

@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants