fix(DataTable, Column): convert date inputs to Date object before comparing their strings#8505
Open
StevenReale wants to merge 1 commit into
Open
Conversation
4 tasks
StevenReale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataTable Date column filters break if a) the column data are strings, which is common when collecting data from an API that transmits as JSON; or b) the filters use some input type other than DatePicker that does not return a Date object, such as a native
<input type="date">element.This PR adds guardrails to
FilterService.jsthat converts the inputs toDateobjects before comparing them.This PR resolves #8506