fix(datatable): fix filter overlay closing when interacting with nested overlay components#8566
Open
VaishnaviD5900 wants to merge 1 commit into
Conversation
…ed overlay components
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
oliversluke
added a commit
to oliversluke/tvheadend
that referenced
this pull request
May 18, 2026
…tream PR Adds a row tracking PrimeVue issues #8537 (MultiSelect) and #8213 (TreeSelect) — DataTable filter popover dismissing on clicks inside a body-portaled overlay widget. The bug shares its root-cause family with the popover-dismiss issue we already fixed downstream in `SettingsPopover.vue` (commit `1ccd62cff`), so the row documents both surfaces. A community contributor (`VaishnaviD5900`) submitted PR [primevue#8566](primefaces/primevue#8566) addressing both issues — uses PrimeVue's existing `data-pc-section` attribute via `closest()` rather than a class-name whitelist, which is cleaner than what our downstream workaround does. The row notes a small follow-up cleanup we can do once that PR merges: swap the hardcoded PrimeVue overlay class selectors in our SettingsPopover for the same `data-pc-section` lookup, dropping the class-name-tracking burden. Also captures a separate-path idea for a helper composable (`useOverlayAwareClickOutside()`) to expose this pattern for downstream consumers — explicitly deferred until #8566 merges so the in-flight bug-fix isn't conflated with an API-design ask. Signed-off-by: Oliver Sluke <22557015+oliversluke@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using components like MultiSelect, Select, or TreeSelect as custom
filters inside a DataTable column, the filter overlay panel closed
immediately upon interacting with any option.
Root Cause
The
isOutsideClickedmethod inColumnFilteronly checked if theclicked target was inside
this.overlay. However, nested overlay panels(like MultiSelect dropdown) are appended to the body by default, so they
exist outside
this.overlayin the DOM, causing them to be incorrectlytreated as outside clicks.
Additionally, the
overlayEventListenerhad a condition that preventedselfClickfrom being set correctly for nested overlays.Fix
overlayEventListenerto always setselfClick = truewhen any overlay-click event is received
isOutsideClickedto check if the target is inside any activeoverlay panel using
closest('[data-pc-section="panel"], [data-pc-section="overlay"]')How to Test
panel should stay open
Closes
Closes #8537
Closes #8213