fix(treeselect): reset selfClick after overlay click to prevent doubl…#8567
Open
VaishnaviD5900 wants to merge 1 commit into
Open
fix(treeselect): reset selfClick after overlay click to prevent doubl…#8567VaishnaviD5900 wants to merge 1 commit into
VaishnaviD5900 wants to merge 1 commit into
Conversation
…e outside-click to close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7966
When clicking on the header slot of a TreeSelect, the click-outside-to-close
functionality required two outside clicks to close the panel instead of one.
Root Cause
onOverlayClicksetsselfClick = truewhen the overlay is clicked, whichis correct for preventing the panel from closing. However it was never reset
after the interaction completed, causing the next outside click to be
incorrectly treated as a self-click and ignored.
Fix
Added a
setTimeout(() => { this.selfClick = false }, 0)at the end ofonOverlayClickto reset the flag after all click events from thatinteraction have fired.
How to Test
Closes
Closes #7966