Chore: Should fix nightly GitHub Action#8581
Open
pieterocp wants to merge 3 commits into
Open
Conversation
…from the others + stop storing the GitHub token to .git/config Signed-off-by: Pieter Oliver <pieter.oliver@nourishcare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in node 22+24, stop 1 failure from blocking getting feedback from the others + stop storing the GitHub token to .git/config.
Defect Fixes
If this is one where an issue is needed, can make one? But given this is not direct functionality it's probably a 🤷.
Feature Requests
This is not a big feature request AFAIK.
(I would also recommend pinning every GitHub action incase of upstream hacking, e.g. see
tj-actionsfor what sort of thing could go wrong.)And this removes the "issue closer" GitHub action since that was compromised and has now been taken down. If this ran 3 hours later, this would have exfiltrated secrets which is no good.