Fixed #8534 - DatePicker: manual input reverts to previous value in t…#8584
Open
tomasgodoi wants to merge 1 commit into
Open
Fixed #8534 - DatePicker: manual input reverts to previous value in t…#8584tomasgodoi wants to merge 1 commit into
tomasgodoi wants to merge 1 commit into
Conversation
…value in timeOnly (24h) mode When typing a time in a DatePicker configured with `timeOnly` and the default 24-hour format, the parsing regex in `parseDateTime` does not capture an am/pm group, so `populateTime` is called with `ampm === undefined`. The subsequent `ampm.toLowerCase()` call then throws a TypeError, which is silently swallowed by the try/catch in `onInput`, leaving the model unchanged. On blur the input is reset from `rawValue`, so the typed value visibly reverts to the previous one. Guard the `pm` assignment so it only inspects `ampm` when defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…imeOnly (24h) mode
When typing a time in a DatePicker configured with
timeOnlyand the default 24-hour format, the parsing regex inparseDateTimedoes not capture an am/pm group, sopopulateTimeis called withampm === undefined. The subsequentampm.toLowerCase()call then throws a TypeError, which is silently swallowed by the try/catch inonInput, leaving the model unchanged. On blur the input is reset fromrawValue, so the typed value visibly reverts to the previous one.Guard the
pmassignment so it only inspectsampmwhen defined.Defect Fixes
When submitting a PR, please also create an issue documenting the error.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Closes #8534