Legendre trait now uses accelerated Jacobi#102
Merged
Conversation
davidnevadoc
approved these changes
Nov 23, 2023
davidnevadoc
left a comment
davidnevadoc
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the improvement. LGTM!
jonathanpwang
pushed a commit
to axiom-crypto/halo2curves
that referenced
this pull request
Nov 29, 2023
legendre trait now uses accelerated jacobi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on #95
As discussed with @CPerezz at ProgCrypto, without a trait for Legendre it would not be possible to use it generically in algorithms like hash-to-curve or for testing, requiring a macro or individual implementation on a per-curve basis.
Unfortunately the new implementation is incompatible with pasta-curves as those are private, in general it's extremely hard to work with them (impossible to add assembly for example), this might be problematic for Nova over a cycle of curve (cc @huitseeker )
This PR reworks the fast modular inversion and Legendre symbol in a ff_ext folder as they definitely should be upstreamed.
The Legendre trait has been changed to not derive from
ff::Fieldand outputi64