[WIP] Batch verification for ECDSA#22
Open
davidnevadoc wants to merge 9 commits into
Open
Conversation
f8045f8 to
02793d1
Compare
This was referenced May 18, 2022
ECDSAECDSA
Variation of the batch multiplication algorithm for ecdsa verification.
Update to keep up with the refactored version
306109c to
f455b25
Compare
Contributor
|
Hi @davidnevadoc, is this PR still being worked on? I'd love such feature :) |
Contributor
Author
|
Hey @enricobottazzi ! I'm not working in this feature anymore. Maybe we could merge this, WDYT @kilic ? |
Contributor
|
Cool! A little off topic: do you think it would be worth creating a chip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to explore different methods for efficient batch verification of ECDSA signatures.
Particularly in the
secp256k1curve.Approach 1
To accomplish this we make 2 changes in this PR:
mul_batch_ecdsafunction for ecc chipbatch_verifyfunction to the ecdsa chip(142K rows per signature)
Approach 2
Using ECDSA* signatures. (For this approach to be really usable it will need to be integrated with the challenge interface.)
The prover must provide the correct point
Rfor the signature'srparameter.