WIP: Motif search - #1549
Conversation
jamesmkrieger
left a comment
jamesmkrieger
left a comment
There was a problem hiding this comment.
Thanks for adding this new functionality. It sounds good. I still need to look through it properly though.
In the meantime, if you could reverse all the unrelated formatting changes, that would be make it much easier to follow. Thanks
|
Everything look much better now. Thanks. Still if you could replace f strings with older types of formatting, that would be great. We need compatibility with python 2.7 for building the prody website. |
| @@ -0,0 +1,491 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
|
|||
| """This module prase protein sequences using PROSITE motifs.""" | |||
There was a problem hiding this comment.
I think there's a typo here. prase is not a word that I know. Do you mean parse? If so, it should be conjugated as parses
| from concurrent.futures import ThreadPoolExecutor | ||
|
|
||
| import requests | ||
| import requests_cache |
There was a problem hiding this comment.
it's best to make these changes inside your function to not make importing prody fail if someone doesn't install this module.
| return compression_type | ||
|
|
||
|
|
||
| def openFile(filename: str) -> Any: |
There was a problem hiding this comment.
This takes precedence over the existing openFile in prody/utilities/pathtools because of the import order and breaks other code because it doesn't support other arguments like the original does. Rename or remove it
3 participants
This feature adds possibility to search for a MOTIF using Prody package.