refactor(redteam): adopt input contracts in UI#9549
Conversation
…-architecture-boundaries
…ckage-artifact-smoke
…re-boundaries' into mdangelo/codex/add-package-artifact-smoke
…act-smoke' into mdangelo/codex/export-contracts-subpath
…subpath' into mdangelo/codex/lazy-load-aws-provider-family
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…-architecture-boundaries
…ngelo/codex/add-package-artifact-smoke
…o/codex/export-contracts-subpath
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…-contracts-subpath # Conflicts: # architecture/layers.json # scripts/testPackageArtifact.ts # test/scripts/architectureUtils.test.ts
…subpath' into HEAD
…vider-family' into HEAD
…pi-contracts' into HEAD
# Conflicts: # src/contracts/index.ts
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ianw-oai
left a comment
ianw-oai
left a comment
There was a problem hiding this comment.
Looks good. This is a mechanical UI import migration to the contracts-owned input types.
…t-browser-api-contracts # Conflicts: # architecture/layers.json # src/contracts/index.ts # src/providers/families/aws.ts # test/integration/library-exports.integration.test.ts # test/package-manifests.test.ts # test/providers/registry.test.ts # test/scripts/architectureUtils.test.ts
…t-browser-api-contracts
…pi-contracts' into mdangelo/codex/extract-browser-api-contracts # Conflicts: # test/contracts/index.test.ts
…pi-contracts' into mdangelo/codex/adopt-ui-input-contracts
mldangelo
requested review from
a team,
alandelong-oai and
daneschneider-oai
as code owners
3 participants
Summary
@promptfoo/contracts@promptfoo/typesWhy
The input contracts were already extracted into the leaf-safe contracts surface. This PR moves the existing browser consumers onto that boundary without mixing in unrelated UI type migrations.
Stack
Verification
npm run architecture:checknpm run test:app -- src/pages/redteam/setup/components/Targets/InputsEditor.test.tsx src/pages/redteam/setup/components/Targets/CommonConfigurationOptions.test.tsx src/pages/redteam/setup/components/Targets/tabs/VariableSelectionDialog.test.tsx --run --sequence.shuffle=falsenpm run build:appnpx @biomejs/biome check src/app/src/pages/redteam/setup/components/Targets/InputsEditor.tsx src/app/src/pages/redteam/setup/components/Targets/CommonConfigurationOptions.tsx src/app/src/pages/redteam/setup/components/Targets/tabs/VariableSelectionDialog.tsx src/app/src/pages/redteam/setup/types.ts src/app/src/pages/redteam/setup/components/Targets/CommonConfigurationOptions.test.tsx src/app/src/pages/redteam/setup/components/Targets/InputsEditor.test.tsx