Skip to content

[WRAPPER] Fix out-of-bounds memory corruption in my_readlink #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptitSeb merged 1 commit into from
Jun 29, 2026
+3 −2
Merged

[WRAPPER] Fix out-of-bounds memory corruption in my_readlink #3995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/wrapped/wrappedlibc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,9 +2113,10 @@ EXPORT ssize_t my_readlink(x64emu_t* emu, void* path, void* buf, size_t sz)
sprintf(cmdline_name, "/proc/%d/cmdline", pid);
FILE* cmdline = fopen(cmdline_name, "r");
if(cmdline) {
ssize_t sz = 0;
ssize_t sz_cmd = 0;
char filename[4096] = {0}; // first arg should be the program name
sz = fread(filename, 1, 4095, cmdline); // keep last char to end the string
sz_cmd = fread(filename, 1, 4095, cmdline); // keep last char to end the string
sz = sz_cmd > sz ? sz : sz_cmd;
fclose(cmdline);
if(filename[0]=='/') {
// absolute path, easy...
Expand Down
Loading