[CORE] Separate the malloc function for box64 itself and the emulated app#4004
Open
zengdage wants to merge 1 commit into
Open
[CORE] Separate the malloc function for box64 itself and the emulated app#4004zengdage wants to merge 1 commit into
zengdage wants to merge 1 commit into
Conversation
886469f to
d2d4976
Compare
…ks of the emulated application
Owner
|
Nope. By doing this, you will break every box32 application. I cannot accept this PR |
Contributor
Author
My apologies, I haven’t yet figured out why this change breaks box32. Could you help explain this to me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging WeChat and its embedded Electron application, I encountered several memory access errors. After comparative analysis against native x86-64 execution, I found that certain memory blocks are allocated via the app’s self-implemented malloc on x86-64, whereas under Box64 emulation, these allocations fall back to the libc native malloc. This difference triggers runtime crashes in WeChat and its Electron app.
This patch fully isolates Box64’s internal malloc from the emulated program’s custom malloc implementation when the environment variable BOX64_MALLOC_HACK=2 is set, resolving the above crash issue.