[INTERP] Added unaligned handling for more opcodes#4013
Open
ksco wants to merge 1 commit into
Open
Conversation
ptitSeb
reviewed
Jul 3, 2026
| GETEW(0); | ||
| GETGW; | ||
| #if defined(DYNAREC) && !defined(TEST_INTERPRETER) | ||
| if(((uintptr_t)ED)&1) { |
Owner
There was a problem hiding this comment.
Are you sure this is an improvement? Using a lock instead of the partial atomic move seems a regression to me.
Collaborator
Author
There was a problem hiding this comment.
Old code is not really unaligned. I guess I could fix it but I decided to align with other similar opcode (to simply use a lock).
Owner
There was a problem hiding this comment.
Ah, well, old code is buggy, as it was supposed to use _b instead if _h...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.