Skip to content

Add more Pulp Exceptions.#1440

Merged
quba42 merged 1 commit into
pulp:mainfrom
aKlimau:add-pulp-exceptions
Jun 12, 2026
Merged

Add more Pulp Exceptions.#1440
quba42 merged 1 commit into
pulp:mainfrom
aKlimau:add-pulp-exceptions

Conversation

@aKlimau

@aKlimau aKlimau commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Assisted-by: Claude Sonnet 4.6 noreply@anthropic.com

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

@aKlimau aKlimau marked this pull request as draft April 21, 2026 13:14
@aKlimau aKlimau force-pushed the add-pulp-exceptions branch 6 times, most recently from 61abafd to 26799ca Compare April 23, 2026 10:11
@aKlimau aKlimau marked this pull request as ready for review April 23, 2026 10:21
@aKlimau aKlimau force-pushed the add-pulp-exceptions branch 8 times, most recently from de94a5e to b1b54b6 Compare April 29, 2026 13:17
@aKlimau aKlimau force-pushed the add-pulp-exceptions branch from b1b54b6 to e3388cb Compare May 4, 2026 13:29
Comment thread pulp_deb/app/tasks/synchronizing.py
Comment thread pulp_deb/app/tasks/synchronizing.py Outdated
Comment thread pulp_deb/app/exceptions.py Outdated
Comment thread pulp_deb/app/exceptions.py Outdated
@aKlimau aKlimau force-pushed the add-pulp-exceptions branch from e3388cb to 4c58f8d Compare May 29, 2026 09:27
"""
Copy content from one repo to another.

Args:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, these look plain wrong...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do look wrong. Don't look like they were copied from pulp_rpm either. Perhaps from some early development state and then we forgot to read them during review? 😰 I may dig through the history at some point to try and understand what happened here. Probably my fault. Certainly out of scope for this PR...

Comment thread pulp_deb/app/tasks/copy.py
@aKlimau aKlimau force-pushed the add-pulp-exceptions branch from 4c58f8d to d0790a5 Compare May 29, 2026 12:25
@quba42

quba42 commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

I will try to review this next/soon. It fixes our deprecation warnings, so thanks for that! Just need to find some time to do it...

Comment thread CHANGES/+add-pulp-exceptions.feature Outdated
Comment thread pyproject.toml Outdated
@aKlimau aKlimau force-pushed the add-pulp-exceptions branch 2 times, most recently from 0ddecd2 to 1433538 Compare June 9, 2026 11:30
  Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@aKlimau aKlimau force-pushed the add-pulp-exceptions branch from 1433538 to d04259c Compare June 10, 2026 08:31

@quba42 quba42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. All discussions resolved. I looked over it one more time and deliberately triggered some (not all) of the errors in oci-env.

Most importantly, this fixes our deprecation warnings. @aKlimau thanks for fixing this for us and thanks for always keeping it up to date so it can keep moving along!

@quba42 quba42 merged commit d79ab15 into pulp:main Jun 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants