Skip to content

Set background-color on search input #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pete-murphy wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Set background-color on search input #1409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea5ed8b
Set background-color on search input
pete-murphy Jul 13, 2026
3d96917
chore: add to CHANGELOG
pete-murphy Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
Bugfixes:
* Fix flaky `SQLITE_IOERR_TRUNCATE` on Windows when multiple spago processes connect concurrently to the cache DB, by skipping `PRAGMA journal_mode = WAL` when it's already enabled (WAL mode is persistent in the DB file header) and tolerating the race on the initial set
* Retry transient network failures (connection errors and 5xx responses) when fetching package tarballs and calling the registry API, instead of failing immediately
* Add `backgroundColor` to search input (in `docs-search` app) so text remains legible when system's color scheme is dark

## [1.0.4] - 2026-03-30

Expand Down
3 changes: 2 additions & 1 deletion docs-search/client-halogen/src/Docs/Search/App/SearchField.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Docs.Search.App.SearchField where

import Prelude

import CSS (border, borderRadius, color, em, float, floatLeft, fontWeight, lineHeight, marginBottom, marginLeft, paddingBottom, paddingLeft, paddingRight, paddingTop, pct, px, rgb, solid, weight, width)
import CSS (backgroundColor, border, borderRadius, color, em, float, floatLeft, fontWeight, lineHeight, marginBottom, marginLeft, paddingBottom, paddingLeft, paddingRight, paddingTop, pct, px, rgb, solid, weight, white, width)
import Data.Maybe (Maybe(..), maybe)
import Data.Newtype (wrap)
import Docs.Search.URIHash as URIHash
Expand Down Expand Up @@ -172,6 +172,7 @@ render state =
pursuitColor = rgb 0x1d 0x22 0x2d
rds = px 3.0

backgroundColor white

@pete-murphy pete-murphy Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check until after making this change, but Pursuit has different dark mode styles for its search input:

.top-banner__form input {
  border: 1px solid #1d222d;
  border-radius: 3px;
  background-color: #ffffff;
  color: #1d222d;
  font-weight: 300;
  line-height: 2;
  padding: 0.21em 0.512em;
  width: 100%;
}
@media (prefers-color-scheme: dark) {
  .top-banner__form input {
    border-color: #1d222d;
    background-color: #141417;
    color: #dedede;
  }
}
Image

Maybe we should match that? Would mean moving the style declaration to insertStyle in App.purs so we can use the media query. Nevermind, should be even simpler than that, we should be able to just re-use the same styles from Pursuit CSS (and delete a lot of inline styles here) by using the same classes as Pursuit.

border solid (px 1.0) pursuitColor
borderRadius rds rds rds rds
color pursuitColor
Expand Down
Loading