Repository navigation
v0.1.6: fix 1 Astra P1 findings (2026-10-22 wave) - #7
Merged
Merged
Conversation
…o-symlink directory chain An ancestor directory swapped for a symlink after is_indexable() could redirect the open outside the vault; O_NOFOLLOW covers only the last component. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding 1 (tools.py:159 ancestor symlink swap): FIXED. Real TOCTOU: O_NOFOLLOW covers only the final component. New indexer.open_resolved() walks from / with dir_fd + O_NOFOLLOW at every component; used by tools._read_note and indexer._read_note. Test: tests/test_tools.py::test_get_rejects_ancestor_directory_swapped_after_validation (fails on base with the canary served, passes on branch).
Full suite (fox-n1, py3.12 venv): 607 passed, 18 skipped, 3 failed (test_ctrl_c_* SIGINT tests; identical 3 failures on unmodified base when run under Ray, environmental).
🤖 Generated with Claude Code
https://claude.ai/code/session_01YK9RAF9uX37A3hDZqR7ppw