Update authorization header and add user agent#1
Open
MichaelZhang-Navex wants to merge 1 commit into
Open
Conversation
Member
|
Sorry for the slow review here, and thank you for digging into the export failure. After looking through the change, the User-Agent addition looks harmless to me, but I am hesitant about removing the Bearer prefix from the Authorization header in this code path. This script constructs the raw HTTP request itself, and the direct Logfire examples I found still use Authorization: Bearer ... Could you share a bit more detail on how you reproduced the problem?
That would make it much easier to separate a header-format issue from something else in the request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello dear maintainers, I installed it following the instructions and see the
OTLP export failederror. I diged into it and found that the header of post request to logfire trace api should be in this way somehow.