Expose ResolvedVariable reason#1945
Merged
Merged
Conversation
Deploying logfire-docs with
|
| Latest commit: |
8e159cc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ed77882.logfire-docs.pages.dev |
| Branch Preview URL: | https://codex-resolved-variable-reas.logfire-docs.pages.dev |
c0ce570 to
338239f
Compare
Contributor
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
alexmojaki
commented
May 21, 2026
Comment on lines
+294
to
+295
| label=serialized_result.label, | ||
| version=serialized_result.version, |
Collaborator
Author
There was a problem hiding this comment.
so was the missing label/version just a bug in main?
Collaborator
Author
There was a problem hiding this comment.
(AI) Yes, that looks like a pre-existing bug in main: the validation-error path already fell back to the code default while preserving the exception, but it rebuilt ResolvedVariable without carrying over the selected provider label/version. This PR fixes that while doing the _reason -> reason rename.
2ad2395 to
bbb9f94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #1731 without the unrelated variable composition changes.
Tests