Skip to content

Require handlebars for template field validation#1957

Open
alexmojaki wants to merge 2 commits into
feature/variable-push-validationfrom
codex/remove-py39-push-validation
Open

Require handlebars for template field validation#1957
alexmojaki wants to merge 2 commits into
feature/variable-push-validationfrom
codex/remove-py39-push-validation

Conversation

@alexmojaki
Copy link
Copy Markdown
Collaborator

Summary

  • remove the Python 3.9-era no-op path from template field validation
  • require the handlebars-backed validator to run when collecting template field issues
  • remove stale skip decorators from the template field validation push tests

Tests

  • uv run pytest tests/test_push_variables.py -q
  • uv run ruff check logfire/variables/_handlebars.py logfire/variables/abstract.py tests/test_push_variables.py
  • uv run pyright logfire/variables/_handlebars.py logfire/variables/abstract.py tests/test_push_variables.py

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant