Skip to content

Require handlebars for template field validation#1957

Closed
alexmojaki wants to merge 2 commits into
feature/variable-push-validationfrom
codex/remove-py39-push-validation
Closed

Require handlebars for template field validation#1957
alexmojaki wants to merge 2 commits into
feature/variable-push-validationfrom
codex/remove-py39-push-validation

Conversation

@alexmojaki
Copy link
Copy Markdown
Collaborator

@alexmojaki alexmojaki commented May 22, 2026

Summary

  • remove the Python 3.9-era no-op path from template field validation
  • require the handlebars-backed validator to run when collecting template field issues
  • remove stale skip decorators from the template field validation push tests

Tests

  • uv run pytest tests/test_push_variables.py -q
  • uv run ruff check logfire/variables/_handlebars.py logfire/variables/abstract.py tests/test_push_variables.py
  • uv run pyright logfire/variables/_handlebars.py logfire/variables/abstract.py tests/test_push_variables.py

devin-ai-integration[bot]
devin-ai-integration Bot reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@alexmojaki alexmojaki mentioned this pull request May 22, 2026
Open
@dmontagu
Copy link
Copy Markdown
Contributor

dmontagu commented Jun 2, 2026

Folded into #1953 — your "Require handlebars for template field validation" commit (06e3704) was cherry-picked onto the rebuilt #1953 branch with your authorship preserved, so the py39 is_handlebars_available no-op removal and the stale skip decorators are gone there. This also fixes #1953's coverage failure (the py39 return [] branch was permanently uncovered on the 3.10+ matrix). Closing this as redundant; credit retained in the commit. Thanks @alexmojaki!

@dmontagu dmontagu closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexmojaki @dmontagu