Support OpenAI Responses API content parts#1981
Open
RitwijParmar wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Ritwij Aryan Parmar <ritwij.aryan.parmar@gmail.com>
8249198 to
fec0bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1901.
This fills in the Responses API content-part gap in the OpenAI instrumentation:
input_textnow maps to a text part/event instead of falling through as unknowninput_imagehandles the Responses API's flatimage_urlstring as well asfile_idand inline file datainput_filemaps URL and file-id references to document URI parts, and inlinefile_datato a document blob partgen_ai.unknownI kept unknown/future part types on the existing generic fallback, so this should be narrowly scoped to the documented Responses API part types.
Tests run:
uv run pytest tests/otel_integrations/test_openai.py -q -k "input_to_events or convert_responses_inputs"uv run ruff check logfire/_internal/integrations/llm_providers/openai.py tests/otel_integrations/test_openai.pyuv run ruff format --check --diff logfire/_internal/integrations/llm_providers/openai.py tests/otel_integrations/test_openai.pyuv run pyright logfire/_internal/integrations/llm_providers/openai.py tests/otel_integrations/test_openai.pyAI disclosure: I used AI assistance while editing and reviewing this patch, then ran the tests and checks above locally.