-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix GoogleModelSettings.google_cached_content so request omits system_instruction, tools, and tool_config
#5681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dsfaccini
merged 10 commits into
pydantic:main
from
gaurav0107:fix/5671-googlemodelsettings-google-cached-conten
Jun 2, 2026
+603
−5
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1c2a70e
fix(google): omit `system_instruction`, `tools`, `tool_config` when `…
gaurav0107 673e078
test(google): parametrize `google_cached_content` test and add stream…
dsfaccini e0df9dc
feat(google): warn when `google_cached_content` strips instructions o…
dsfaccini cadacdc
style(google): backtick-wrap dropped field names in cached-content wa…
dsfaccini 178d179
test(google): replace mocks with VCR for `google_cached_content`
dsfaccini f83c032
docs(google): un-skip cached-content example, add cache-creation snippet
dsfaccini cddbce4
fix(google): enable JSON mode when `google_cached_content` strips too…
dsfaccini 3fff5d1
Merge branch 'main' into fix/5671-googlemodelsettings-google-cached-c…
dsfaccini 2a33f33
test(google): move `google_cached_content` tests to `tests/models/goo…
dsfaccini f752cfa
Merge branch 'main' into fix/5671-googlemodelsettings-google-cached-c…
dsfaccini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.