fix(messages): add InstructionPart to ModelRequestPart discriminated union#5697
Open
devteamaegis wants to merge 2 commits into
Open
fix(messages): add InstructionPart to ModelRequestPart discriminated union#5697devteamaegis wants to merge 2 commits into
devteamaegis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
InstructionParthaspart_kind: Literal['instruction'] = 'instruction'and itsdocstring states "Part type identifier, used as a discriminator for deserialization."
It can appear in
ModelRequest.partsduring normal agent runs, but it was notincluded in the
ModelRequestPartdiscriminated union.As a result, any serialized message history containing an
InstructionPartin itspartslist would fail to reload:This silently corrupted message histories in Temporal/durable-exec workflows, resumed
runs, and any code that persists history to JSON and reloads it.
Fix
Add
Annotated[InstructionPart, pydantic.Tag('instruction')]to theModelRequestPartunion (one line change in
messages.py).Tests
Added
TestInstructionParts::test_instruction_part_in_parts_roundtrip— a regressiontest that round-trips a
ModelRequestcontaining both static and dynamicInstructionPartinstances alongside aUserPromptPartthroughdump_json→validate_jsonand asserts full fidelity.Fixes #5696.