fix: round-trip instruction request parts#5698
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
7c41f02 to
fc93d3c
Compare
fc93d3c to
a4ce8f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5696.
Summary
InstructionPartto theModelRequestParttagged unionModelMessagesTypeAdapter.dump_json()/validate_json()for request instruction partsTo verify
uv run python -c "from pydantic_ai.messages import ModelRequest, InstructionPart, ModelMessagesTypeAdapter; messages=[ModelRequest(parts=[InstructionPart(content='rule', dynamic=True)])]; serialized=ModelMessagesTypeAdapter.dump_json(messages); print(serialized.decode()); print(ModelMessagesTypeAdapter.validate_json(serialized))"uv run pytest tests/test_messages.py::TestInstructionParts -quv run pytest tests/test_messages.py -q -k "InstructionParts or model_messages_type_adapter" -p no:cacheprovideruv run ruff check pydantic_ai_slim\pydantic_ai\messages.py tests\test_messages.pyuv run python -m py_compile pydantic_ai_slim\pydantic_ai\messages.py tests\test_messages.pygit diff --checkI also ran the full
tests/test_messages.py; it still has unrelated local Windows/environment failures intest_document_url_formats[csv](mimetypesreturnsapplication/vnd.ms-excel) andtest_binary_content_from_path(permission denied underC:\Users\He\AppData\Local\Temp\pytest-of-He).The secondary
BinaryImagedemotion mentioned in the issue is not changed here.