test: add deferral negative cases and local ignores#5739
Open
ChunkyTortoise wants to merge 3 commits into
Open
test: add deferral negative cases and local ignores#5739ChunkyTortoise wants to merge 3 commits into
ChunkyTortoise wants to merge 3 commits into
Conversation
Verify that ModelRetry (ToolRetryError) and unexpected exceptions still record spans as ERROR on v5 instrumentation -- only CallDeferred and ApprovalRequired get UNSET status. Addresses the missing negative cases called out in tests/AGENTS.md: 'Test both positive and negative cases for optional capabilities.' Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The second test used the too-broad pytest.raises(Exception) which was flagged by the B017 linter rule. Since the tool explicitly raises ValueError, narrow to pytest.raises(ValueError, match=...) to validate the specific exception type and message. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueErrorbehavior.Verification
git diff --check-> passedNotes