fix(messages): preserve RunUsage on response roundtrip#5747
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
size: S
he-yufeng
force-pushed
the
fix/model-response-run-usage
branch
from
2878aac to
72dc3e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelResponse.usageto deserialize either per-request usage or run-level usageRequestUsageso existing stored messages still round-trip as beforeRunUsage.requestsandRunUsage.tool_callssurviving JSON round-tripFixes #5744.
To verify
PYTHONUTF8=1 uv run pytest tests\test_messages.py::test_pre_usage_refactor_messages_deserializable tests\test_messages.py::test_model_response_preserves_run_usage_roundtrip tests\test_messages.py::test_file_part_serialization_roundtrip -qPYTHONUTF8=1 uv run ruff check pydantic_ai_slim\pydantic_ai\messages.py tests\test_messages.pyPYTHONUTF8=1 uv run ruff format --check pydantic_ai_slim\pydantic_ai\messages.py tests\test_messages.pyPYTHONUTF8=1 PYRIGHT_PYTHON_IGNORE_WARNINGS=1 uv run pyright pydantic_ai_slim\pydantic_ai\messages.py tests\test_messages.pyI also ran the full
tests\test_messages.pyfile. The new usage-related tests passed; the full file still has two Windows-local platform failures unrelated to this change (.csvMIME detection and CRLF bytes fromPath.write_text).