Add rewrite for diag(A @ B) to avoid materializing the product#2302
Open
jessegrabowski wants to merge 2 commits into
Open
Add rewrite for diag(A @ B) to avoid materializing the product#2302jessegrabowski wants to merge 2 commits into
jessegrabowski wants to merge 2 commits into
Conversation
jessegrabowski
added
graph rewriting
linalg
Member
|
@jessegrabowski I generalized the rewrite into (A @ B)[advanced_indexing], which covers the Diagonal and other cases. Same approach we have for other ExtractDiag(of stuff) |
ricardoV94
reviewed
Jul 19, 2026
| assert_allclose(f(np.array([0, 1, 1, 3])), 0.0) # duplicate column -> singular | ||
|
|
||
|
|
||
| class TestDiagOfDot: |
Member
There was a problem hiding this comment.
these tests should be removed/go to the test_subtensor_lift ? I kept them untouched to show no regression from the original commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2301