Repository navigation
Conversation
all_dependencies_complex rebuilt each external dependency from its string form, dropping the editable flag set by path sources, so they were installed non-editable. Reuse the original Dependency objects for strings that pass through resolve_extras unchanged. Fixes pypa#2448
Member
|
This regresses path sources that are requested with extras, which might have been a latent bug hidden by the bug you are fixing. Path sources now go through the editable branch in virtual.py:289, which passes only dependency.path to the installer. So canary[foo] gets installed as -e /path/canary and foo's dependencies are never installed. Keeping the extras on the editable path fixes it: extras = f"[{','.join(sorted(dependency.extras))}]" if dependency.extras else ""
user_editable_dependencies.append(f"{dependency.path}{extras}")If you would not mind making that change as well to ensure that things work as intended Also, environments created before this change stay non-editable, because the dependency hash doesn't include editable. That might be worth mentioning in the changelog. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all_dependencies_complex rebuilt each external dependency from its string form, dropping the editable flag set by path sources, so they were installed non-editable. Reuse the original Dependency objects for strings that pass through resolve_extras unchanged.
Fixes #2448