Repository navigation
Conversation
all_dependencies_complex rebuilt each requirement from its string, which dropped the editable flag path sources set. The flag is copied back onto file requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2448
A path source is documented as editable by default.
decorate_dependenciessets that flag, thenall_dependencies_complexrebuilds each requirement fromstr(dependency). That string does not carry the flag, so the dependency is installed as a normal file URL.File requirements that were editable are marked editable again after extras are expanded.
Tests:
pytest tests/env/plugin/test_interface.py::TestEnvironmentSources::test_path_source_rewrites_dependency