Repository navigation
Count shared-data and shared-scripts as wheel file selection - #2466
Closed
Cherith1222 wants to merge 1 commit into
Closed
Cherith1222 wants to merge 1 commit into
Cherith1222 wants to merge 1 commit into
Conversation
A wheel target that only defines shared-data or shared-scripts no longer raises the 'Unable to determine which files to ship' error, matching force-include. AI-assisted (Cursor); not yet reviewed by a human.
Member
|
https://hatch.pypa.io/latest/community/contributing/#ai-contributions - There needs to be a human in the loop. The description already indicates this policy is violated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A wheel target that set only
shared-scriptsorshared-datawas treated as having no file selection, and the build raised "Unable to determine which files to ship".force-includealready counts as selection.shared-scriptsandshared-datanow do too.Fixes #1973.
The unreleased hatchling history note is in
docs/history/hatchling.md. Closed pull request #2262 touched the same issue and was not merged; this branch does not copy that diff. The maintainer there asked for a shorter comment and for issue numbers to stay out of the tests.Test Plan
On Windows, Python 3.13:
pytest tests/backend/builders/test_wheel.py -k considered_selection→ before the change, 2 failed and 3 passed; after,tests/backend/builders/test_wheel.pywas 109 passed and 7 skipped.Not run: the rest of the hatch tests,
hatch fmt --check, ruff, mypy, other Python versions, and non-Windows.AI assistance
Drafted with Cursor. The account owner authorized opening this pull request. A human has not reviewed the diff. There is no
Co-authored-by,Reviewed-by, orSigned-off-bytrailer.