Preserve explicit plate subsamples during replay - #3471
Open
aswanth-07 wants to merge 1 commit into
Open
Conversation
aswanth-07
marked this pull request as ready for review
August 28, 2026 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
poutine.replaynow preserves caller-provided indices atpyro.plate(..., subsample=...)sites. Automatically generated plate subsamples still replay from the guide so model and guide minibatches remain aligned.The change fixes the silent mismatch reported in #3468. A default
AutoGuideno longer replaces a model's explicit subsample with an independently generated guide index.Fixes #3468
Validation
pytest -q tests/infer/test_autoguide.py -k "replay_preserves_explicit_subsample or replay_plates or subsample_guide": 53 passed. Optional Funsor cases were excluded because Funsor is not installed in the local environment.pytest -q tests/poutine: 3036 passed.ruff check pyro/poutine/replay_messenger.py tests/infer/test_autoguide.py: passed.black --check pyro/poutine/replay_messenger.py tests/infer/test_autoguide.py: passed.mypy --warn-unused-ignores pyro/poutine/replay_messenger.py tests/infer/test_autoguide.py: passed.pyro/_version.pyoutside this diff.AI assistance disclosure: AI-assisted development tools were used during investigation and implementation. The reported tests were run against the final diff.