-
-
Notifications
You must be signed in to change notification settings - Fork 11
feat(detections): add recorded_at field for capture-time sequence linking #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Acruve15
wants to merge
5
commits into
main
Choose a base branch
from
alexis/510-detection-recorded-at
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
be1bcd1
feat(detections): add recorded_at column with backfill migration
Acruve15 1fc9ffe
feat(detections): drive sequence linking off recorded_at
Acruve15 d56a559
feat(detections): normalize recorded_at to UTC
Acruve15 c727ed7
Merge origin/main into alexis/510-detection-recorded-at
Acruve15 25edadc
fix(e2e): assert sequence started_at against recorded_at
Acruve15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/migrations/versions/2026_05_27_1000-c4e9f1a2b3d5_add_recorded_at_to_detections.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| """add recorded_at column to detections and backfill from created_at | ||
|
|
||
| Revision ID: c4e9f1a2b3d5 | ||
| Revises: b3d8a9c1e2f4 | ||
| Create Date: 2026-05-27 10:00:00.000000 | ||
|
|
||
| """ | ||
|
|
||
| from typing import Sequence, Union | ||
|
|
||
| import sqlalchemy as sa | ||
| from alembic import op | ||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision: str = "c4e9f1a2b3d5" | ||
| down_revision: Union[str, None] = "b3d8a9c1e2f4" | ||
|
Acruve15 marked this conversation as resolved.
Dismissed
|
||
| branch_labels: Union[str, Sequence[str], None] = None | ||
|
Acruve15 marked this conversation as resolved.
Dismissed
|
||
| depends_on: Union[str, Sequence[str], None] = None | ||
|
Acruve15 marked this conversation as resolved.
Dismissed
|
||
|
|
||
|
|
||
| def upgrade() -> None: | ||
| # Add as nullable first so existing rows don't violate the NOT NULL constraint. | ||
| op.add_column("detections", sa.Column("recorded_at", sa.DateTime(), nullable=True)) | ||
| # Backfill: legacy detections have no capture time, so fall back to the DB insertion time. | ||
| op.execute("UPDATE detections SET recorded_at = created_at WHERE recorded_at IS NULL") | ||
| # Tighten to NOT NULL to match the SQLModel definition. | ||
| op.alter_column("detections", "recorded_at", nullable=False) | ||
|
|
||
|
|
||
| def downgrade() -> None: | ||
| op.drop_column("detections", "recorded_at") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.