Skip to content

fix: correct FRLM flow coverage annotation #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samay2504 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct FRLM flow coverage annotation #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spopt/locate/flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def add_combination_refueling_constraints(
class FRLMCoverageMixin:
"""Mixin to calculate flow coverage statistics for FRLM."""

def get_flow_coverage(self) -> None:
def get_flow_coverage(self) -> dict[str, float]:
"""Improved and fixed calculation of flow coverage."""
if not hasattr(self, "facility_vars") or self.facility_vars is None:
raise AttributeError(
Expand Down
1 change: 1 addition & 0 deletions spopt/tests/test_locate/test_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ def test_flow_objective(self, setup_network_with_distances):
result = model.solve(solver=pulp.PULP_CBC_CMD(msg=0))
assert result["status"] == "Optimal"
coverage = model.get_flow_coverage()
assert isinstance(coverage, dict)
assert coverage["covered_volume"] == 50

def test_vmt_objective(self, setup_network_with_distances):
Expand Down
Loading