Skip to content

Pulp v4 compatibility#527

Open
FirePheonix wants to merge 9 commits into
pysal:mainfrom
FirePheonix:pulp-v4-compat
Open

Pulp v4 compatibility#527
FirePheonix wants to merge 9 commits into
pysal:mainfrom
FirePheonix:pulp-v4-compat

Conversation

@FirePheonix

Copy link
Copy Markdown

based on discussions and conclusions done on: pysal/libpysal#907,
the following PR solves all PULP v4 issues on spopt.

@codecov

codecov Bot commented Apr 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.1%. Comparing base (9b36063) to head (68036b9).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
spopt/locate/flow.py 71.9% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #527     +/-   ##
=======================================
+ Coverage   76.9%   77.1%   +0.2%     
=======================================
  Files         29      29             
  Lines       3700    3751     +51     
=======================================
+ Hits        2846    2891     +45     
- Misses       854     860      +6     
Files with missing lines Coverage Δ
spopt/locate/base.py 95.0% <100.0%> (+0.6%) ⬆️
spopt/locate/coverage.py 97.8% <100.0%> (ø)
spopt/locate/p_center.py 100.0% <100.0%> (ø)
spopt/locate/p_median.py 98.7% <100.0%> (+0.1%) ⬆️
spopt/locate/flow.py 73.1% <71.9%> (-0.1%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jGaboardi

Copy link
Copy Markdown
Member

Let's hold off on this review until we get @ljwolf's on pysal/libpysal#907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants