ani-cli in a 'Scriptrunner for Termux' script does not work with parameters since 5.1.1

[Noddy81]

Metadata (please complete the following information)
Version: 5.1.1.
OS: Android 13
Shell: Termux
Anime: all

Describe the bug
Since 5.1.1 no longer able to call ani-cli in a bash script.

ani-cli works if typed into termux but if the same command is pulled from a .sh file, it results in the error:

/data/data/com.termux/files/usr/bin/ani-cli[601]: /data/data/com.termux/files/usr/bin/printf: Argument list too long

Steps To Reproduce

1. Run ani-cli -d --dub flcl -r1--1
2. Create script.sh file
3. Add 'ani-cli -d --dub flcl -r1--1` and save
   4.. bash script.sh
   Expected behavior
   Downloading will work only on step 1, not step 4

[port19x]

Eyo the fuck? Lemme get on that, thx for the report

[U-L-M-S]

@Noddy81 I created a PR that may fix your problem. I used this script as base:

#!/data/data/com.termux/files/usr/bin/bash
ani-cli -d --dub flcl -r 1--1

[Noddy81]

@U-L-M-S Thanks. I tested the ani-cli file in the PR and it works on my termux+android.

[U-L-M-S]

@U-L-M-S Thanks. I tested the ani-cli file in the PR and it works on my termux+android.

nice !!! let's see what @port19x has to say about it.
Maybe it needs one or more changes 😄

[port19x]

I wonder why android doesn't use the termux printf

[U-L-M-S]

I wonder why android doesn't use the termux printf

what ??? I thought I fixed it already(#1897 ) ... also... it worked on my machine 😆

[port19x]

Yeah, hence I'm hesitant to merge your linked PR, because to me this looks like misconfiguration / user error, not a bug in ani-cli

[Noddy81]

Yes and no.

I was using the same termux config and script.sh (containing ani-cli commands for the 10 shows I'm collecting in separate subfolders) on ani-cli versions 4.x.x and it worked well (even if anidb.app was slow on dubs). I would call up the script.sh using

bash /storage/emulated/0/Download/Anime/script.sh

from a 'Scriptrunner for Termux' script that has a shortcut on the homescreen of my android phone. Easier than checking missed calls.

I think that the changeover to HiAnime is where the demands of ani-cli exceeded the limits of 'Scriptrunner for Termux'.

I did extra testing today and yes ani-cli ver 5.1.2. will run a script.sh full of ani-cli commands with all parameters if I open a termux window, and manually type

bash /storage/emulated/0/Download/Anime/script.sh

It does not work when I call the same script using the same command in a 'Scriptrunner for termux' script. It did work on 4.x.x.

That said, @U-L-M-S has written code that does allow ani-cli and a script.sh full of ani-cli commands to be called from the 'Scriptrunner for Termux' shortcut on my phone, so I am fine with using his fork until such time as ani-cli changes hosts again. By then I should have 2TB filled.

@U-L-M-S very much appreciated.