Let an extension be named apart from its Cargo artifact - #73
Merged
timkpaine merged 1 commit intoAug 21, 2026
Merged
Conversation
The Python extension filename was always derived from the Cargo artifact stem, so the cdylib had to be named for the module it becomes. A project whose extension links a core library of the same name then emits two cdylibs called the same thing into target/, which collide on Windows. Add an optional python-extension-name on an artifact to supply the module stem directly, freeing the Cargo lib name to be unique.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 86.08% 86.52% +0.43%
==========================================
Files 11 11
Lines 1538 1551 +13
==========================================
+ Hits 1324 1342 +18
+ Misses 214 209 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python extension filename was always derived from the Cargo artifact stem, so the cdylib had to be named for the module it becomes. A project whose extension links a core library of the same name then emits two cdylibs called the same thing into target/, which collide on Windows.
Add an optional python-extension-name on an artifact to supply the module stem directly, freeing the Cargo lib name to be unique.