Fix TopoJson non-collection geometries#2250
Open
KhadeerBasha1232 wants to merge 1 commit into
Open
Conversation
Author
|
This fixes #1816 — TopoJson raised a KeyError('geometries') when the Fix checks Added a parametrized test covering both Polygon and MultiPolygon cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1816
Problem
When a TopoJSON's
objectsentry had atypeofPolygonorMultiPolygon(instead ofGeometryCollection), folium raised:This happened because the code assumed every object had a
geometrieskey and didn't handle "bare" geometry objects that store their arcs
directly.
Fix
Updated the TopoJson handling in
folium/features.pyso it alsosupports non-collection geometry types (
Polygon,MultiPolygon,etc.), not just
GeometryCollection.Testing
Reproduced the exact example from #1816 — it rendered without the
KeyError after this change. Ran the existing test suite locally with
python -m pytest tests --ignore=tests/seleniumand all tests pass.