Implement SharedPtrDataLoader load_into - #22004
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22004
Note: Links to docs will display an error until the docs builds have been completed.
|
|
Hi @CatNebulaaaa! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
There was a problem hiding this comment.
Pull request overview
Implements SharedPtrDataLoader::load_into() so callers can copy data directly into a provided destination buffer, reusing the loader’s existing bounds/overflow validation and matching the null-destination behavior of other DataLoader implementations.
Changes:
- Add
SharedPtrDataLoader::load_into()implementation that validates destination buffer and delegates range validation toload(). - Add unit tests covering null destination handling, successful copies, and out-of-bounds requests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extension/data_loader/shared_ptr_data_loader.h | Implements load_into() for SharedPtrDataLoader using existing validation and memcpy. |
| extension/data_loader/test/shared_ptr_data_loader_test.cpp | Adds tests for load_into() success, null destination, and invalid range handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| buffer), | ||
| Error::Ok); | ||
| EXPECT_EQ(0, std::memcmp(buffer, data.get() + kDataSize - sizeof(buffer), 3)); |
|
@pytorchbot label "release notes: none" |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Fixes #11562
Test plan
AI usage
This change was developed with assistance from OpenAI Codex. I reviewed the resulting diff and ran the tests listed above.