Skip to content

Add FP16 support to BundleIO error statistics - #22018

Open
mansnils wants to merge 1 commit into
pytorch:mainfrom
mansnils:misc
Open

Add FP16 support to BundleIO error statistics#22018
mansnils wants to merge 1 commit into
pytorch:mainfrom
mansnils:misc

Conversation

@mansnils

@mansnils mansnils commented Aug 21, 2026 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator

Output verification is already FP16-aware.
This fixes only the reported statistics for FP16:

  • Zero difference: was potentially reported incorrectly; now reports 0.
  • Within tolerance: still passes, but now reports correct non-zero diff.
  • Exceeds tolerance: still fails, but now reports the correct diff.

Preserve existing FP32 handling, add correct FP16 dtype dispatch, and reject unsupported output dtypes explicitly. Add regression coverage for FP32 and FP16 statistics.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @Sebastian-Larsson @robell @rascani

@mansnils
Add FP16 support to BundleIO error statistics
181d12e 
Output verification is already FP16-aware.
This fixes only the reported statistics for FP16:
- Zero difference: was potentially reported incorrectly; now reports 0.
- Within tolerance: still passes, but now reports correct non-zero diff.
- Exceeds tolerance: still fails, but now reports the correct diff.

Preserve existing FP32 handling, add correct FP16 dtype dispatch,
and reject unsupported output dtypes explicitly. Add regression
coverage for FP32 and FP16 statistics.

Signed-off-by: Måns Nilsson <mans.nilsson@arm.com>
Change-Id: I6f80db612448e03e6928e5d1113e3a316b7466bc
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: devtools Changes to dev tooling, for example the debugger & profiler labels Aug 21, 2026
@pytorch-bot

pytorch-bot Bot commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22018

Note: Links to docs will display an error until the docs builds have been completed.

❌ 265 New Failures, 13 Unrelated Failures, 51 Unclassified Failures

As of commit 181d12e with merge base 4cf0207 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

  • periodic / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • periodic / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • periodic / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • periodic / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • periodic / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • periodic / test-models-linux (cmake, vit, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • pull / test-coreml-bc-macos (macos-m1-stable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • pull / test-coreml-bc-macos (macos-m2-stable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / llm-server / linux / linux-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/home/ec2-user/actions-runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-coreml-delegate / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-custom-ops-macos (cmake) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-huggingface-transformers-macos (bert|coreml_fp32_gpu|--quantize) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-huggingface-transformers-macos (distilbert|coreml_fp32_gpu|--quantize) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-huggingface-transformers-macos (llama3.2-1b|coreml_fp32_gpu|--quantize) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-huggingface-transformers-macos (olmo-1b|coreml_fp32_gpu|--quantize) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-huggingface-transformers-macos (qwen3-0.6b|coreml_fp32_gpu|--quantize) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-huggingface-transformers-macos (smollm2-135m|coreml_fp32_gpu|--quantize) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-llama-runner-mac (fp32, coreml) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-llama-runner-mac (fp32, mps) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-llama-runner-mac (fp32, xnnpack+custom+quantize_kv) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-llama-torchao-lowbit / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (dl3) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (edsr) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (efficient_sam) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (emformer_join) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (emformer_transcribe) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (ic3) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (ic4) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (mobilebert) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (mv2) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (mv3) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (resnet50) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (vit) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-coreml (w2l) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (efficient_sam, portable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (emformer_join, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (ic4, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (llama, portable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (llama2, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (llama3_2_vision_encoder, portable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (mobilebert, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (mv3, portable) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (mv3, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (resnet50, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (vit, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-cpu (w2l, xnnpack-quantization-delegation) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-models-macos-mps / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-multimodal-macos (gemma3-4b) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/runner/work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-selective-build-macos (cmake) / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • trunk / test-static-llama-ane / macos-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    ##[error]fatal: clone of 'https://gitlab.com/libeigen/eigen.git' into submodule path '/Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/optimized/third-party/eigen' failed
  • Windows MSVC Build / build-windows-msvc / windows-job (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner
@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia Gasoonjia is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: devtools Changes to dev tooling, for example the debugger & profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mansnils